From 99f10c5210b857e1ea7ff24ffc17969a81353be5 Mon Sep 17 00:00:00 2001 From: Bernd Steckmeister Date: Fri, 3 Jul 2026 06:30:40 +0200 Subject: [PATCH] style: doppelte Unterstriche in Closure-Parametern bereinigen MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Dart 3 erlaubt mehrere Wildcard-Parameter mit demselben Namen "_" in einem Scope, daher sind __ / ___ für ungenutzte Callback-Parameter (pageBuilder, errorBuilder etc.) unnötig. Rein mechanische Änderung, keine Verhaltensänderung. Co-Authored-By: Claude Sonnet 5 --- lib/features/call/voice_channel.dart | 2 +- lib/features/chat/attachment_dialog.dart | 4 ++-- lib/features/chat/document_viewer.dart | 4 ++-- lib/features/chat/gif_sticker_picker.dart | 6 +++--- lib/widgets/mxc_image.dart | 4 ++-- lib/widgets/pyramid_loader.dart | 4 ++-- lib/widgets/search_modal.dart | 2 +- lib/widgets/settings_modal.dart | 2 +- lib/widgets/share_target_dialog.dart | 4 ++-- 9 files changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/features/call/voice_channel.dart b/lib/features/call/voice_channel.dart index 4ffe4d1..fb8e475 100644 --- a/lib/features/call/voice_channel.dart +++ b/lib/features/call/voice_channel.dart @@ -689,7 +689,7 @@ class _ParticipantStrip extends StatelessWidget { return ListView.separated( scrollDirection: isVertical ? Axis.vertical : Axis.horizontal, itemCount: participants.length, - separatorBuilder: (_, __) => const SizedBox(width: 12, height: 12), + separatorBuilder: (_, _) => const SizedBox(width: 12, height: 12), itemBuilder: (context, i) => SizedBox( width: isVertical ? double.infinity : 101 * participants[i].aspectRatio, height: 101, diff --git a/lib/features/chat/attachment_dialog.dart b/lib/features/chat/attachment_dialog.dart index cfa052f..7dd48ab 100644 --- a/lib/features/chat/attachment_dialog.dart +++ b/lib/features/chat/attachment_dialog.dart @@ -30,9 +30,9 @@ class AttachmentDialog extends StatefulWidget { barrierLabel: 'Anhang', barrierColor: Colors.black54, transitionDuration: const Duration(milliseconds: 180), - pageBuilder: (_, __, ___) => + pageBuilder: (_, _, _) => AttachmentDialog(files: files, room: room, replyTo: replyTo), - transitionBuilder: (_, anim, __, child) { + transitionBuilder: (_, anim, _, child) { final curved = CurvedAnimation(parent: anim, curve: Curves.easeOutBack); return FadeTransition( diff --git a/lib/features/chat/document_viewer.dart b/lib/features/chat/document_viewer.dart index 57c8c7a..dce8cfb 100644 --- a/lib/features/chat/document_viewer.dart +++ b/lib/features/chat/document_viewer.dart @@ -734,9 +734,9 @@ class _PdfFullscreenViewer extends StatefulWidget { opaque: true, barrierColor: Colors.black, transitionDuration: const Duration(milliseconds: 180), - pageBuilder: (_, __, ___) => + pageBuilder: (_, _, _) => _PdfFullscreenViewer(bytes: bytes, filename: filename, initialPage: initialPage), - transitionsBuilder: (_, anim, __, child) => FadeTransition(opacity: anim, child: child), + transitionsBuilder: (_, anim, _, child) => FadeTransition(opacity: anim, child: child), )); } diff --git a/lib/features/chat/gif_sticker_picker.dart b/lib/features/chat/gif_sticker_picker.dart index eb18cb3..6a65def 100644 --- a/lib/features/chat/gif_sticker_picker.dart +++ b/lib/features/chat/gif_sticker_picker.dart @@ -538,7 +538,7 @@ class _GifStickerPickerState extends State child: Image.network( thumbUrl, fit: BoxFit.contain, - errorBuilder: (_, __, ___) => Container(color: _pt!.bg2), + errorBuilder: (_, _, _) => Container(color: _pt!.bg2), ), ), ); @@ -587,7 +587,7 @@ class _StickerCellState extends State<_StickerCell> { Image.network( widget.piUrl, fit: BoxFit.contain, - errorBuilder: (_, __, ___) => Container(color: pt.bg2), + errorBuilder: (_, _, _) => Container(color: pt.bg2), ), if (showOverlay) Positioned( @@ -666,7 +666,7 @@ class _GifCell extends StatelessWidget { fit: StackFit.expand, children: [ Image.network(imageUrl, fit: BoxFit.cover, - errorBuilder: (_, __, ___) => Container(color: PyramidTheme.of(context).bg3)), + errorBuilder: (_, _, _) => Container(color: PyramidTheme.of(context).bg3)), if (isHovered || isFavorite) Positioned( top: 4, right: 4, diff --git a/lib/widgets/mxc_image.dart b/lib/widgets/mxc_image.dart index 809818f..00239b8 100644 --- a/lib/widgets/mxc_image.dart +++ b/lib/widgets/mxc_image.dart @@ -90,7 +90,7 @@ class _MxcAvatarState extends State { width: widget.size, height: widget.size, fit: BoxFit.cover, - errorBuilder: (_, __, ___) => widget.placeholder(context), + errorBuilder: (_, _, _) => widget.placeholder(context), ), ); } @@ -194,7 +194,7 @@ class _MxcImageState extends State { width: widget.width, height: widget.height, gaplessPlayback: true, - errorBuilder: (_, __, ___) => + errorBuilder: (_, _, _) => widget.placeholder ?? const SizedBox.shrink(), ); } diff --git a/lib/widgets/pyramid_loader.dart b/lib/widgets/pyramid_loader.dart index 22643b1..664de3a 100644 --- a/lib/widgets/pyramid_loader.dart +++ b/lib/widgets/pyramid_loader.dart @@ -60,7 +60,7 @@ class _PyramidLoaderState extends State final painter = AnimatedBuilder( animation: _ctrl, - builder: (_, __) => CustomPaint( + builder: (_, _) => CustomPaint( painter: _PyramidPainter( yaw: _yawAt(_ctrl.value), accent: accent, @@ -82,7 +82,7 @@ class _PyramidLoaderState extends State fit: BoxFit.contain, repeat: true, animate: true, - errorBuilder: (_, __, ___) => painter, + errorBuilder: (_, _, _) => painter, ), ), ), diff --git a/lib/widgets/search_modal.dart b/lib/widgets/search_modal.dart index 3679c05..ef7c648 100644 --- a/lib/widgets/search_modal.dart +++ b/lib/widgets/search_modal.dart @@ -723,7 +723,7 @@ class _SearchThumbState extends State<_SearchThumb> { height: size, child: _bytes != null ? Image.memory(_bytes!, fit: BoxFit.cover, - errorBuilder: (_, __, ___) => _placeholder(pt)) + errorBuilder: (_, _, _) => _placeholder(pt)) : _placeholder(pt), ), ); diff --git a/lib/widgets/settings_modal.dart b/lib/widgets/settings_modal.dart index 08c12cb..36c478e 100644 --- a/lib/widgets/settings_modal.dart +++ b/lib/widgets/settings_modal.dart @@ -1306,7 +1306,7 @@ class _ProfileSectionState extends ConsumerState<_ProfileSection> { children: [ if (_pendingServerBanner != null) Image.memory(_pendingServerBanner!, fit: BoxFit.cover, - errorBuilder: (_, __, ___) => const SizedBox.shrink()) + errorBuilder: (_, _, _) => const SizedBox.shrink()) else if (existingMxc != null && client != null) MxcImage(mxcUri: existingMxc, client: client, fit: BoxFit.cover) else diff --git a/lib/widgets/share_target_dialog.dart b/lib/widgets/share_target_dialog.dart index ae76319..0694230 100644 --- a/lib/widgets/share_target_dialog.dart +++ b/lib/widgets/share_target_dialog.dart @@ -27,8 +27,8 @@ class ShareTargetDialog { barrierLabel: 'Teilen', barrierColor: Colors.black54, transitionDuration: const Duration(milliseconds: 180), - pageBuilder: (_, __, ___) => _ShareTargetPicker(client: client, share: share), - transitionBuilder: (_, anim, __, child) { + pageBuilder: (_, _, _) => _ShareTargetPicker(client: client, share: share), + transitionBuilder: (_, anim, _, child) { final curved = CurvedAnimation(parent: anim, curve: Curves.easeOutBack); return FadeTransition( opacity: anim,